Skip to content

Commit

Permalink
fix: broken wayland window decorations due to botched chromium update
Browse files Browse the repository at this point in the history
The `GetTitlebarBounds().height()` is obviously intended to be placed in
the `top` parameter, which used to be the second one before upstream
removed multi-parameter `gfx::Rect::Inset`, but it's the first parameter
for `gfx::Insets::TLBR`, which was intended to replace the removed
`Inset` function. However, whoever updated Chromium kept the parameter
unchanged, causing the title bar height to be passed to the `left`
parameter, causing the window title bar to be unclickable.
  • Loading branch information
msizanoen1 committed Jul 19, 2022
1 parent f1746c8 commit e918ae4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion shell/browser/ui/views/client_frame_view_linux.cc
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ gfx::Rect ClientFrameViewLinux::GetBoundsForClientView() const {
if (!frame_->IsFullscreen()) {
client_bounds.Inset(GetBorderDecorationInsets());
client_bounds.Inset(
gfx::Insets::TLBR(0, GetTitlebarBounds().height(), 0, 0));
gfx::Insets::TLBR(GetTitlebarBounds().height(), 0, 0, 0));
}
return client_bounds;
}
Expand Down

0 comments on commit e918ae4

Please sign in to comment.