fix: report more detailed errors in shell.openExternal() on Windows (#…

…33658) Co-authored-by: Milan Burda <milan.burda@gmail.com>
electron · Apr 11, 2022 · ee52147 · ee52147
1 parent 3c6be55
commit ee52147
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/shell/common/platform_util_win.cc b/shell/common/platform_util_win.cc
@@ -251,7 +251,8 @@ std::string OpenExternalOnWorkerThread(
           ShellExecuteW(nullptr, L"open", escaped_url.c_str(), nullptr,
                         working_dir.empty() ? nullptr : working_dir.c_str(),
                         SW_SHOWNORMAL)) <= 32) {
-    return "Failed to open";
+    return "Failed to open: " +
+           logging::SystemErrorCodeToString(logging::GetLastSystemErrorCode());
   }
   return "";
 }