src: provide a variant of LoadEnvironment taking a callback

nodejs/node#30467
electron · May 20, 2021 · f1fcc87 · f1fcc87
1 parent e997b97
commit f1fcc87
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/shell/app/node_main.cc b/shell/app/node_main.cc
@@ -240,7 +240,7 @@ int NodeMain(int argc, char* argv[]) {
     }
 
     v8::HandleScope scope(isolate);
-    node::LoadEnvironment(env);
+    node::LoadEnvironment(env, node::StartExecutionCallback{});
 
     env->set_trace_sync_io(env->options()->trace_sync_io);
 

diff --git a/shell/common/node_bindings.cc b/shell/common/node_bindings.cc
@@ -529,7 +529,7 @@ node::Environment* NodeBindings::CreateEnvironment(
 }
 
 void NodeBindings::LoadEnvironment(node::Environment* env) {
-  node::LoadEnvironment(env);
+  node::LoadEnvironment(env, node::StartExecutionCallback{});
   gin_helper::EmitEvent(env->isolate(), env->process_object(), "loaded");
 }