Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: instructions to get Notifications working on Win 10 Update added (backport: 4-0-x) #16326

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jan 8, 2019

Backport of #16320

See that PR for details.

Notes: Added instructions on getting Notification API to work in Windows 10

Fails silently and was frustratingly hard to know why. Hope this save a lot of people some time.
@trop trop bot requested a review from a team January 8, 2019 16:17
@trop trop bot added 4-2-x backport This is a backport PR labels Jan 8, 2019
@jkleinsc
Copy link
Contributor

jkleinsc commented Jan 8, 2019

Merging as CI failures unrelated to doc change

@jkleinsc jkleinsc merged commit 1f411d3 into electron:4-0-x Jan 8, 2019
@release-clerk
Copy link

release-clerk bot commented Jan 8, 2019

Release Notes Persisted

Added instructions on getting Notification API to work in Windows 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4-2-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants