docs: instructions to get Notifications working on Win 10 Update added #16320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fails silently and was frustratingly hard to know why. Hope this save a lot of people some time.
|
Release Notes Persisted
|
|
Congrats on merging your first pull request! 🎉🎉🎉 |
|
I have automatically backported this PR to "3-1-x", please check out #16324 |
|
I have automatically backported this PR to "4-0-x", please check out #16326 |
|
I have automatically backported this PR to "3-0-x", please check out #16325 |
This was referenced Jan 8, 2019
akisctx
pushed a commit
to akisctx/electron
that referenced
this pull request
Jan 22, 2019
…ron#16320) Fails silently and was frustratingly hard to know why. Hope this save a lot of people some time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Updated docs only. Notifications fail silently and was frustratingly hard to know why. Hope this saves a lot of people time. It's because Windows expects only known apps to be able to send notifications.
Checklist
Release Notes
Notes: Added instructions on getting Notification API to work in Windows 10