Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent double-destroy of window (backport: 4-0-x) #16478

Merged
merged 1 commit into from Jan 22, 2019
Merged

fix: prevent double-destroy of window (backport: 4-0-x) #16478

merged 1 commit into from Jan 22, 2019

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jan 21, 2019

Backport of #16472

See that PR for details.

Notes: Fix crash when closing popup windows.

@trop trop bot requested a review from a team January 21, 2019 22:56
@trop trop bot mentioned this pull request Jan 21, 2019
Merged
@trop trop bot added 4-2-x backport This is a backport PR labels Jan 21, 2019
@codebytere
Copy link
Member

All tests are know flakes.

@codebytere codebytere merged commit e7d7cc3 into electron:4-0-x Jan 22, 2019
@release-clerk
Copy link

release-clerk bot commented Jan 22, 2019

Release Notes Persisted

Fix crash when closing popup windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
4-2-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @zcbenz