fix: prevent double-destroy of window #16472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
approved these changes
Jan 21, 2019
|
Release Notes Persisted
|
|
I have automatically backported this PR to "4-0-x", please check out #16478 |
|
/trop run backport |
|
The backport process for this PR has been manually initiated, here we go! :D |
|
I have automatically backported this PR to "3-1-x", please check out #16512 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix #16202.
On some machines it may happen that the window gets destroyed for twice, and checking web_contents() can effectively guard against that.
I could not find out the root cause as I could not reproduce the crash on my machine, but as discussed in the original issue, this fix can solve the crash, and I don't see any bad side effect.
Release Notes
Notes: Fix crash when closing popup windows.