Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: cancel is optional in OnHeadersReceivedResponse (backport: 4-0-x) #16548

Merged
merged 1 commit into from Jan 30, 2019
Merged

docs: cancel is optional in OnHeadersReceivedResponse (backport: 4-0-x) #16548

merged 1 commit into from Jan 30, 2019

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jan 25, 2019

Backport of #16506

See that PR for details.

Notes: Documented the cancel property in OnHeadersReceivedResponse as optional.

@trop trop bot requested a review from a team January 25, 2019 14:42
@trop trop bot mentioned this pull request Jan 25, 2019
Merged
5 tasks
@trop trop bot added 4-2-x backport This is a backport PR labels Jan 25, 2019
@codebytere codebytere merged commit 0ee1f51 into electron:4-0-x Jan 30, 2019
@release-clerk
Copy link

release-clerk bot commented Jan 30, 2019

Release Notes Persisted

Documented the cancel property in OnHeadersReceivedResponse as optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
4-2-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jkleinsc @codebytere @miniak