Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: cancel is optional in OnHeadersReceivedResponse #16506

Merged
merged 1 commit into from Jan 25, 2019
Merged

docs: cancel is optional in OnHeadersReceivedResponse #16506

merged 1 commit into from Jan 25, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jan 23, 2019

Description of Change

The cancel property is optional for all responses, including OnHeadersReceivedResponse according to the code atom/browser/net/atom_network_delegate.cc

Checklist

Release Notes

Notes: Documented the cancel property in OnHeadersReceivedResponse as optional.

@miniak miniak requested a review from a team January 23, 2019 10:57
@miniak miniak changed the title docs: cancel is optional in OnHeadersReceivedResponse docs: cancel is optional in OnHeadersReceivedResponse Jan 23, 2019
@alexeykuzmin
Copy link
Contributor

@miniak Automatic backport to 3-1-x is not possible, you will have to do it manually.

@jkleinsc
Copy link
Contributor

Merging as CI failures are unrelated to doc change

@jkleinsc jkleinsc merged commit e2516dc into master Jan 25, 2019
@release-clerk
Copy link

release-clerk bot commented Jan 25, 2019

Release Notes Persisted

Documented the cancel property in OnHeadersReceivedResponse as optional.

@trop trop bot mentioned this pull request Jan 25, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Jan 25, 2019

I have automatically backported this PR to "4-0-x", please check out #16548

@trop trop bot removed the target/4-0-x label Jan 25, 2019
@trop trop bot mentioned this pull request Jan 25, 2019
Merged
@trop trop bot added the in-flight/4-0-x label Jan 25, 2019
@trop
Copy link
Contributor

trop bot commented Jan 25, 2019

I have automatically backported this PR to "5-0-x", please check out #16549

@jkleinsc jkleinsc deleted the miniak/doc-fix-cancel branch January 25, 2019 14:43
@sofianguy sofianguy added this to 5.0.0-beta.2 in 5.0.x Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
5.0.x
Fixed in 5.0.0-beta.2
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@miniak @alexeykuzmin @jkleinsc @codebytere