feat: Implement process.getProcessMemoryInfo to get the process memory info #16591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y usage (#14847) * feat: Implement process.getMemoryFootprint to get the process memory usage * Add spec * fix: must enter node env in callback * Update function call * Update spec * Update API data * update spec * Update include * update test for shared bytes * Update atom/common/api/atom_bindings.cc Co-Authored-By: nitsakh <nitsakh@icloud.com> * Update atom/common/api/atom_bindings.cc Co-Authored-By: nitsakh <nitsakh@icloud.com> * Update API * Update the callback isolate * Update to work after app ready * Update docs * Update docs/api/process.md Co-Authored-By: nitsakh <nitsakh@icloud.com> * Update docs/api/process.md Co-Authored-By: nitsakh <nitsakh@icloud.com> * Fix crash
|
|
||
| if (mate::Locker::IsBrowserProcess() && !Browser::Get()->is_ready()) { | ||
| promise->RejectWithErrorMessage( | ||
| "Memory Info is available only after app ready"); |
There was a problem hiding this comment.
Suggested change
| "Memory Info is available only after app ready"); | |
| "Memory information is only available after the app's 'ready' event (See: electronjs.org/docs/api/app)"); |
| memory consumed by the Electron code itself in Kilobytes. | ||
|
|
||
| Returns an object giving memory usage statistics about the current process. Note | ||
| that all statistics are reported in Kilobytes. |
There was a problem hiding this comment.
Suggested change
| that all statistics are reported in Kilobytes. | |
| that all statistics are reported in kilobytes. |
(Typically spelled using lowercase)
|
|
||
| Returns an object giving memory usage statistics about the current process. Note | ||
| that all statistics are reported in Kilobytes. | ||
| This api should be called after app ready. |
There was a problem hiding this comment.
Suggested change
| This api should be called after app ready. | |
| This API should not be called before the `app` has emitted the `ready` event. |
| that all statistics are reported in Kilobytes. | ||
| This api should be called after app ready. | ||
|
|
||
| Chromium does not provide `residentSet` value for macOS. This is because macOS |
There was a problem hiding this comment.
Suggested change
| Chromium does not provide `residentSet` value for macOS. This is because macOS | |
| Chromium does not provide a `residentSet` value for macOS. This is because macOS |
|
|
||
| Chromium does not provide `residentSet` value for macOS. This is because macOS | ||
| performs in-memory compression of pages that haven't been recently used. As a | ||
| result the resident set size value is not what one would expect. `private` memory |
There was a problem hiding this comment.
Suggested change
| result the resident set size value is not what one would expect. `private` memory | |
| result, the resident set size value is not what one would expect. `private` memory |
|
Sorry for the swarm of suggestions, feel free to disregard them as you please. Thank you for the overall effort! |
|
😬 This is a backport of #14847 . Suggestions look good, but I'll probably address those in a separate PR. |
5 tasks
alexeykuzmin
approved these changes
Jan 30, 2019
|
@miniak I agree with Nitish, let's merge those changes separately. |
|
@felixrieseberg Thank you for the suggestions, they're awesome. |
miniak
approved these changes
Jan 30, 2019
MarshallOfSound
approved these changes
Jan 30, 2019
|
Release Notes Persisted
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #14847.
Description of Change
Checklist
npm testpassesRelease Notes
Notes: Added getProcessMemoryInfo API