New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: process.getProcessMemoryInfo() returns a Promise #16593
Conversation
aa098a1
to
54b95ad
Compare
The artifact comparison is broken after #16416 |
There is an issue with the generator. It's producing |
@zcbenz it's still not working properly, it's generating |
54b95ad
to
66be611
Compare
@miniak Can you please fix conflicts here? |
66be611
to
e181cef
Compare
@alexeykuzmin rebased. It's still not generated properly:
|
is likely why it's not generating properly. Check relative paths maybe? |
@codebytere This is a bug in the typescript generator not prefixing the innerType correctly in this case, can hack it in tonight |
@MarshallOfSound did you have time to check the code generator? |
@MarshallOfSound ping on the typescript generator |
e181cef
to
2feb919
Compare
@miniak electron/typescript-definitions#136 will fix this 👍 |
@miniak Bumping |
2feb919
to
ab0bc5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated electron-typescript-definitions
and it all looks good now 👍
Release Notes Persisted
|
* docs: process.getProcessMemoryInfo() returns a Promise * chore: bump electron-typescript-definitions to get Promise<T> fix
Description of Change
Fix
process.getProcessMemoryInfo()
return type, which isPromise<ProcessMemoryInfo>
, not justProcessMemoryInfo
./cc @nitsakh
Checklist
npm test
passesRelease Notes
Notes: Fixed
process.getProcessMemoryInfo()
return type toPromise<ProcessMemoryInfo
inelectron.d.ts
.