Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable inputpane virtual keyboard by default #16944

Merged
merged 1 commit into from Feb 15, 2019
Merged

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Feb 13, 2019

Description of Change

First commit here is just running git-import-patches followed by git-export-patches. The second commit backports https://chromium-review.googlesource.com/c/chromium/src/+/946928 to enable the inputpane virtual keyboard by default, which should fix some scenarios in Windows 10 RS4 and later in which the virtual keyboard wasn't showing when it should have.

Checklist

Release Notes

Notes: Fixed an issue on Windows 10 RS4 and later that was causing the virtual keyboard not to appear when focusing some input fields.

@nornagon nornagon requested review from brenca and a team February 13, 2019 23:41
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, any reason patch was preferred over passing it to --enable-features ?

@nornagon
Copy link
Member Author

I prefer the backport because:

  1. it'll disappear automatically when rebasing (though i suppose in this case, since it's already gone on master, this isn't really an advantage)
  2. it's nice to have a direct backport of code that i know is in chrome
  3. this allows disabling the feature with --disable-features rather than forcing it
  4. i don't know where the "pass extra things to --enable-features" code in Electron is 😅

backports e6c18518b from chromium, fixes #13832
@deepak1556
Copy link
Member

1 and 2 are compelling reasons to have this as a patch :)

Regarding 4 , they are in AtomBrowserMainParts::InitializeFeatureList

@jkleinsc jkleinsc merged commit 969ac4c into 4-0-x Feb 15, 2019
@release-clerk
Copy link

release-clerk bot commented Feb 15, 2019

Release Notes Persisted

Fixed an issue on Windows 10 RS4 and later that was causing the virtual keyboard not to appear when focusing some input fields.

@jkleinsc jkleinsc deleted the fix-virtual-keyboard branch February 15, 2019 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants