Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable inputpane virtual keyboard by default #16944

Merged
merged 1 commit into from Feb 15, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions patches/common/chromium/.patches
Expand Up @@ -90,3 +90,4 @@ sqlite_upgrade_from_3_24_to_3_26.patch
sqlite_update_api_3_26.patch
tts.patch
do_not_allow_impl_side_invalidations_until_frame_sink_is_fully_active.patch
enable_inputpane_virtual_keyboard_functionality_by_default.patch
@@ -0,0 +1,29 @@
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Dave Tapuska <dtapuska@chromium.org>
Date: Mon, 11 Jun 2018 19:26:48 +0000
Subject: Enable InputPane virtual keyboard functionality by default.

Flip feature flag on. New functionality is used for Windows 10 RS4 and
later.

BUG=817501

Change-Id: I3c45ac35f925a3b72f2ff50d5f8fdad4895b3cfd
Reviewed-on: https://chromium-review.googlesource.com/946928
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566102}

diff --git a/ui/base/ui_base_features.cc b/ui/base/ui_base_features.cc
index a2431e836940c4a1fc7fc95f128a2e2d5aab1b02..80add9507320a8e0dfb42f024095870faa7b3e3c 100644
--- a/ui/base/ui_base_features.cc
+++ b/ui/base/ui_base_features.cc
@@ -97,7 +97,7 @@ const base::Feature kUiCompositorScrollWithLayers = {
#if defined(OS_WIN)
// Enables InputPane API for controlling on screen keyboard.
const base::Feature kInputPaneOnScreenKeyboard = {
- "InputPaneOnScreenKeyboard", base::FEATURE_DISABLED_BY_DEFAULT};
+ "InputPaneOnScreenKeyboard", base::FEATURE_ENABLED_BY_DEFAULT};

// Enables using WM_POINTER instead of WM_TOUCH for touch events.
const base::Feature kPointerEventsForTouch = {"PointerEventsForTouch",