Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing buffer size check in nativeImage (backport: 4-1-x) #17567

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Mar 27, 2019

Backport of #17465

See that PR for details.

Notes: Added missing buffer size check in nativeImage.createFromBuffer / nativeImage.addRepresentation. Data URLs only parsed according to the MIME type as PNG or JPEG.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 27, 2019
@trop trop bot added 4-2-x backport This is a backport PR labels Mar 27, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 27, 2019
@codebytere codebytere merged commit e1a8050 into electron:4-1-x Mar 27, 2019
@release-clerk
Copy link

release-clerk bot commented Mar 27, 2019

Release Notes Persisted

Added missing buffer size check in nativeImage.createFromBuffer / nativeImage.addRepresentation. Data URLs only parsed according to the MIME type as PNG or JPEG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4-2-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants