Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing buffer size check in nativeImage #17465

Merged
merged 1 commit into from Mar 26, 2019
Merged

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Mar 19, 2019

Description of Change

  • Added missing buffer size check in nativeImage.createFromBuffer / nativeImage.addRepresentation.
  • Separated the code into properly named helpers.
  • Data URLs only parsed according to the MIME type as PNG or JPEG.

Checklist

Release Notes

Notes: Added missing buffer size check in nativeImage.createFromBuffer / nativeImage.addRepresentation. Data URLs only parsed according to the MIME type as PNG or JPEG.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 19, 2019
@miniak miniak self-assigned this Mar 20, 2019
@miniak miniak marked this pull request as ready for review March 20, 2019 18:54
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 20, 2019
@zcbenz zcbenz merged commit 95df531 into master Mar 26, 2019
@release-clerk
Copy link

release-clerk bot commented Mar 26, 2019

Release Notes Persisted

Added missing buffer size check in nativeImage.createFromBuffer / nativeImage.addRepresentation. Data URLs only parsed according to the MIME type as PNG or JPEG.

@zcbenz zcbenz deleted the miniak/native-image branch March 26, 2019 01:13
@miniak
Copy link
Contributor Author

miniak commented Mar 27, 2019

/trop run backport-to 4-1-x

@trop
Copy link
Contributor

trop bot commented Mar 27, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "4-1-x" here we go! :D

@trop
Copy link
Contributor

trop bot commented Mar 27, 2019

I have automatically backported this PR to "4-1-x", please check out #17567

@trop trop bot added the in-flight/4-1-x label Mar 27, 2019
@miniak
Copy link
Contributor Author

miniak commented Mar 27, 2019

/trop run backport-to 5-0-x

@trop
Copy link
Contributor

trop bot commented Mar 27, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "5-0-x" here we go! :D

@trop
Copy link
Contributor

trop bot commented Mar 27, 2019

I have automatically backported this PR to "5-0-x", please check out #17568

@miniak
Copy link
Contributor Author

miniak commented Mar 27, 2019

/trop run backport-to 3-1-x

@trop
Copy link
Contributor

trop bot commented Mar 27, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "3-1-x" here we go! :D

@trop
Copy link
Contributor

trop bot commented Mar 27, 2019

I have automatically backported this PR to "3-1-x", please check out #17569

@sofianguy sofianguy added this to Fixed in 5.0.0-beta.7 in 5.0.x Mar 28, 2019
@sofianguy sofianguy added this to Fixed in 3.1.8 in 3.1.x Mar 29, 2019
@sofianguy sofianguy added this to Fixed (3.1.8) in 3.0.x / 3.1.x May 1, 2019
kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
3.0.x / 3.1.x
Fixed (3.1.8)
3.1.x
Fixed in 3.1.8
5.0.x
Fixed in 5.0.0-beta.7
Development

Successfully merging this pull request may close these issues.

None yet

2 participants