Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App freeze when iframe is deleted from a webview #17890

Closed
3 tasks done
ghost opened this issue Apr 20, 2019 · 3 comments
Closed
3 tasks done

App freeze when iframe is deleted from a webview #17890

ghost opened this issue Apr 20, 2019 · 3 comments

Comments

@ghost
Copy link

ghost commented Apr 20, 2019

Preflight Checklist

  • I have read the Contributing Guidelines for this project.
  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version:
    • 5.0.0-beta.9
  • Operating System:
    • macOS Mojave
  • Last Known Working Electron version::
    • 4.1.4

Expected Behavior

The iframe is removed without causing any issue

Actual Behavior

The webview content will freeze (the gif will stop working) once the iframe is removed from it and in some cases, you will be unable to close the app.

To Reproduce

Run the following Electron Fiddle: https://gist.github.com/ae270063bc98401e6f6cbfeb1fddfa5d

It will remove the iframe after 6 seconds. The gif should then freeze on the latest beta (9) and in some cases, closing the app is impossible unless force exiting.

Screenshots

Additional Information

After further testing, I noticed that if the iframe is restored then the app start acting normally again.

@r0stig
Copy link
Contributor

r0stig commented May 6, 2019

Able to reproduce in 5.0.1.

Is this a regression? Sounds very similar to this if you look at the linked comment #14211 (comment)

@codebytere
Copy link
Member

@r0stig @pwnsdx yeah, i'd imagine there's some issue where the OOPIF is not properly reconnected when the renderer process restarts. I'll try to poke at this soon.

@sofianguy
Copy link
Contributor

fixed #18976

@sofianguy sofianguy moved this from Unsorted Issues to Fixed in 5.0.7 in 5.0.x Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
5.0.x
Fixed in 5.0.7
Development

No branches or pull requests

3 participants