fix: allow stream protocols to return headers with multiple values #18094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…14887) * fix: allow stream protocols to return headers with multiple values This allows stream protocols to return headers with multiple values as an array of values. Fixes #14778 * Prefer ConvertFromV8 * Cleanup header conversion 1. Deduplicate the code by using a lambda 2. Remove duplicate calls to headers->Get(key) * Fix broken test Headers with multiple values are now being converted correctly, this test asserted the wrong behavior.
4 tasks
MarshallOfSound
approved these changes
May 1, 2019
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Backport of #14887
Checklist
npm testpassesRelease Notes
Notes: Fixed returning headers with multiple values for stream protocols.