Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow stream protocols to return headers with multiple values #18094

Merged
merged 1 commit into from May 1, 2019
Merged

fix: allow stream protocols to return headers with multiple values #18094

merged 1 commit into from May 1, 2019

Commits on May 1, 2019

  1. fix: allow stream protocols to return headers with multiple values (#… 

    …14887)

* fix: allow stream protocols to return headers with multiple values

This allows stream protocols to return headers with multiple values as
an array of values.

Fixes #14778

* Prefer ConvertFromV8

* Cleanup header conversion

1. Deduplicate the code by using a lambda
2. Remove duplicate calls to headers->Get(key)

* Fix broken test

Headers with multiple values are now being converted correctly, this
test asserted the wrong behavior.
    @ibash @miniak
    ibash authored and miniak committed May 1, 2019
    Copy the full SHA
    c0533d5 View commit details
    Browse the repository at this point in the history