Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow setting of global fallback user agent #18110

Merged
merged 1 commit into from May 2, 2019
Merged

feat: allow setting of global fallback user agent #18110

merged 1 commit into from May 2, 2019

Conversation

MarshallOfSound
Copy link
Member

Backport of #18016

See that PR for details. Approved for 4.2.0 backport by @electron/wg-releases on 01/05/19

Notes: Added new app.userAgentFallback property to allow setting the apps useragent globally

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 2, 2019
@trop trop bot mentioned this pull request May 2, 2019
Merged
@MarshallOfSound MarshallOfSound added the fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases label May 2, 2019
@MarshallOfSound MarshallOfSound marked this pull request as ready for review May 2, 2019 01:16
@MarshallOfSound
Copy link
Member Author

This is slightly different to the master PR as we have to send the user-agent over the process arguments in order to support the override for service workers. In 4-0-x the service worker UA is initialized in the renderer. In master it is initialized in the browser process so we don't have this work around.

@codebytere codebytere added 4-2-x backport This is a backport PR and removed new-pr 🌱 PR opened in the last 24 hours labels May 2, 2019
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 2, 2019
@MarshallOfSound MarshallOfSound merged commit 9a665eb into 4-2-x May 2, 2019
@release-clerk
Copy link

release-clerk bot commented May 2, 2019

Release Notes Persisted

Added new app.userAgentFallback property to allow setting the apps useragent globally

@MarshallOfSound MarshallOfSound deleted the global-ua-4 branch May 2, 2019 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees
No one assigned
Labels
4-2-x backport This is a backport PR fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases new-pr 🌱 PR opened in the last 24 hours
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MarshallOfSound @deepak1556 @codebytere