New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow setting of global fallback user agent #18016
Conversation
Put this on the @electron/wg-releases agenda to discuss |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be awesome if this was set as a property on the prototype instead :)
0a13c3c
to
e50aa19
Compare
lint death ☝️ |
e50aa19
to
05fea02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but i'd love a second review before we merge this.
Release Notes Persisted
|
I was unable to backport this PR to "6-0-x" cleanly; |
A maintainer has manually backported this PR to "4-2-x", please check out #18110 |
1 similar comment
A maintainer has manually backported this PR to "4-2-x", please check out #18110 |
* feat: allow setting of global fallback user agent * spec: add tests for app.set/getUserAgentFallback
A maintainer has manually backported this PR to "6-0-x", please check out #18473 |
Currently we support letting apps set user agents on
webContents
andsession
but not "for everything". Well this PR allows you to do just that. In particular it allows apps to do a few thingsNotes: Added new
app.userAgentFallback
property to allow setting the apps useragent globally