New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
De-prioritize SimSun and PMingLiu in the default font fallback list #18197
Comments
I was hoping you'd also fill out the part of the template that specifies the Electron version that you saw this issue in, as we've changed some font fallback things in recent versions. In general we tend to follow Chrome's behaviour as closely as we can. For instance, #15486 changed Electron's fallback fonts to match Chrome's. If you believe that this is not the optimal fallback font behaviour for Chrome, consider filing a bug against Chrome at https://crbug.com/new. |
@nornagon Considering that this issue is sent by people from Microsoft (as what you may already know) who is working on the CJK font experience of Windows, I suggest you to treat Believe's opinion prior to the official default behavior of Google Chromium. If the source code of Edge Chromium is available, its behavior (which is optimized by Microsoft) can be your new reference. |
Moving the discussion of this issue (with Chromium) to here: |
The Electron version reported on this issue is no longer supported. See our supported versions documentation. If this is still reproducible on a supported version, please open a new issue with any other new information that a maintainer should know. Thank you for taking the time to report this issue and helping to make Electron better! Your help is appreciated. |
Preflight Checklist
Problem Description
In current Chromium font fallback implementation, the prioritized font for Simplified Chinese and Traditional Chinese are set to SimSun and PMingLiu on purpose, which is very inconsistent with most western typefaces.
https://cs.chromium.org/chromium/src/third_party/blink/renderer/platform/fonts/win/font_fallback_win.cc
https://www.zhihu.com/question/323244457/answer/675834621
Proposed Solution
Prioritize “Microsoft YaHei” and “Microsoft JhengHei” instead.
Alternatives Considered
A better solution may be defining multiple font fallback sequences for different font styles: one for serif, one for sans-serif, and have different priority for specific fonts.
Additional Information
The text was updated successfully, but these errors were encountered: