build: fixes for CI flakes in 3-1-x #18523
Conversation
Turns off ELECTRON_ENABLE_LOGGING/ELECTRON_ENABLE_STACK_DUMPING in Windows as they are causing issues. In Linux, use a newer version of python-dbusmock to resolve dbusmock hanging on dbus_stop
| RUN apt-get install -y python-dbusmock | ||
| # Install python-dbus | ||
| RUN apt-get install -y python-dbus | ||
| RUN pip install python-dbusmock |
There was a problem hiding this comment.
It looks like it can make sense to port this piece to all other release branches.
Just to avoid issues with python-dbusmock in case there will be a need to rebuild a Docker container for any of them.
There was a problem hiding this comment.
@alexeykuzmin the newer branches use a newer base docker image which already pulls in a newer version of python-dbusmock, so it is only really needed for 3-1-x
There was a problem hiding this comment.
I've recently built a Docker container from the 4-2-x branch Dockerfile to run tests in, and often see exactly the same failures because of dbus timeouts.
So it looks like the current Docker containers used for E4 builds just happen to have a version of python-dbusmock not affected by that issue.
So I think that pip install python-dbusmock should be used for E4+ builds as well to make sure we always use a newer version of python-dbusmock, which doesn't have the timeout issue.
There was a problem hiding this comment.
By the way, do you know exactly which version of python-dbusmock works fine?
Should be specify this version in the Dockerfile explicitly?
It is probably the latest available today 0.18.1, am I right?
|
No Release Notes |
Currently in 3-1-x both Windows and Linux CI are erroring out with two separate issues:
Windows flakes on the
app module mixed sandboxtests. This is due to Re-enable mixed-sandbox tests for Windows CI #13770 (comment). This PR fixes that issue by turning off ELECTRON_ENABLE_LOGGING/ELECTRON_ENABLE_STACK_DUMPING on Appveyor builds.Linux builds are timing out but passing tests. It turns out that dbusmock was hanging on
dbus_stop. This PR changes the docker container to use a newer version of python-dbusmock which adds timeouts to dbus_stop.Description of Change
Checklist
npm testpassesRelease Notes
Notes: no-notes