New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: install python-dbusmock via pip for a Docker container #18589
Conversation
To prevent timeout errors with some other python-dbusmock versions.
@alexeykuzmin what timeout errors were we seeing? do you have links to relevant tests that were dying, by chance? |
@codebytere see the second bullet point in the #18523 linked in the description. |
@jkleinsc I remember you saying that all containers for branches > 3 work fine, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexeykuzmin the change I was picking up for 3-1-x was the change to actually have a timeout on dbus_stop, which you can see was added in 0.17: https://github.com/martinpitt/python-dbusmock/blob/master/NEWS#L31
We still see the timeout message, but it works better than before where it would wait forever. That I can tell the timeout issue is still in 0.18.2 so I would recommend just changing the Docker file to pull in the latest so that once a new version is released if would pick up this commit:
martinpitt/python-dbusmock@f3b9d61
Co-Authored-By: John Kleinschmidt <jkleinsc@github.com>
No Release Notes |
I have automatically backported this PR to "6-0-x", please check out #18597 |
I have automatically backported this PR to "4-2-x", please check out #18598 |
I have automatically backported this PR to "5-0-x", please check out #18599 |
Description of Change
To prevent timeout errors with some other python-dbusmock versions.
Related to #18523.
Checklist
npm test
passesRelease Notes
Notes: no-notes