Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can’t input using macOS “Emoji & Symbols” popover #19124

Closed
3 tasks done
javan opened this issue Jul 5, 2019 · 1 comment · Fixed by #19213
Closed
3 tasks done

Can’t input using macOS “Emoji & Symbols” popover #19124

javan opened this issue Jul 5, 2019 · 1 comment · Fixed by #19213
Assignees
@erickzhao
Labels
6-0-x bug/regression ↩️ A new version of Electron broke something platform/macOS
Projects
6.1.x

Comments

@javan
Copy link
Contributor

javan commented Jul 5, 2019 •
edited

Preflight Checklist

  • I have read the Contributing Guidelines for this project.
  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version:
    • 6.0.0-beta.12
  • Operating System:
    • macOS 10.14.5
  • Last Known Working Electron version:
    • 6.0.0-beta.11

Expected Behavior

Selecting a character from the Emoji & Symbols popover should enter it to the focused input

Actual Behavior

The popover closes and no character is input

To Reproduce

  1. $ git clone https://github.com/javan/electron-quick-start.git -b emoji-and-symbols-bug
  2. $ npm install
  3. $ npm start || electron .
  4. Click the Edit → Emoji & Symbols menu or press ⌃⌘Space to open the popover
  5. Select any character from the popover

Screenshots

v6.0.0-beta.12 👎

electron-6-beta-12

v6.0.0-beta.11 👍

electron-6-beta-11

Additional Information

#18995 may be the culprit since it was introduce in beta.12 (cc: @erickzhao @codebytere)
@javan
Copy link
Contributor Author

javan commented Jul 5, 2019 •
edited

Subtle detail: Note that the input loses focus when the popover opens in the beta.12 gif above. In beta.11, focus remains.

@erickzhao erickzhao self-assigned this Jul 5, 2019
@erickzhao erickzhao added bug/regression ↩️ A new version of Electron broke something 6-0-x platform/macOS labels Jul 5, 2019
@erickzhao erickzhao mentioned this issue Jul 6, 2019
Closed
4 tasks
@sofianguy sofianguy added this to Unsorted Issues in 6.1.x Jul 10, 2019
@erickzhao erickzhao mentioned this issue Jul 11, 2019
Merged
5 tasks
@sofianguy sofianguy moved this from Unsorted Issues to Fixed for Next Release in 6.1.x Jul 12, 2019
@sofianguy sofianguy moved this from Fixed for Next Release to Fixed in 6.0.0-beta.14 in 6.1.x Jul 17, 2019
@codebytere codebytere mentioned this issue Jun 24, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erickzhao erickzhao

Labels
6-0-x bug/regression ↩️ A new version of Electron broke something platform/macOS
Projects
No open projects
6.1.x
Fixed in 6.0.0-beta.14
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: revert key -> main change in window delegate listener electron/electron
2 participants
@javan @erickzhao