New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: revert key -> main change in window delegate listener #19213
Conversation
Release Notes Persisted
|
I was unable to backport this PR to "5-0-x" cleanly; |
I was unable to backport this PR to "4-2-x" cleanly; |
I have automatically backported this PR to "6-0-x", please check out #19221 |
/trop run backport |
@erickzhao is not authorized to run PR backports. |
/trop run backport |
The backport process for this PR has been manually initiated, here we go! :D |
A maintainer has manually backported this PR to "5-0-x", please check out #19238 |
A maintainer has manually backported this PR to "4-2-x", please check out #19239 |
Description of Change
Fixes #19124
Reverts #18995, which caused a regression (#19124). According to our discussion in #19128 (comment), it would be best to revert the fix for now, especially since this regression has already been backported into 4.2.X, 5.0.X, and 6.0.X.
For now, the test that I wrote in #18995 has also been commented out.
cc @codebytere @zcbenz @nornagon
Checklist
npm test
passesRelease Notes
Notes: Reverted change to focus behavior that broke Character Viewer support on macOS.