fix: use WeakPtr to detect deletion to avoid crash on application menu #19560

jkleinsc · 2019-08-01T00:10:23Z

Backport of #19257
(cherry picked from commit 77c24d8)

PR description included and stakeholders cc'd
npm test passes
PR title follows semantic commit guidelines
PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Notes: Fixed crashes when using the application menu on Linux.

(cherry picked from commit 77c24d8)

release-clerk · 2019-08-01T15:05:49Z

Release Notes Persisted

Fixed crashes when using the application menu on Linux.

fix: use WeakPtr to detect deletion

4bcf99d

(cherry picked from commit 77c24d8)

jkleinsc added the target/5-0-x label Aug 1, 2019

jkleinsc requested a review from a team as a code owner August 1, 2019 00:10

electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 1, 2019

trop bot mentioned this pull request Aug 1, 2019

fix: use WeakPtr to detect deletion to avoid crash on application menu #19257

Merged

4 tasks

jkleinsc removed the target/5-0-x label Aug 1, 2019

jkleinsc changed the title ~~fix: use WeakPtr to detect deletion~~ fix: use WeakPtr to detect deletion to avoid crash on application menu Aug 1, 2019

codebytere added 6-0-x app-feedback-program backport This is a backport PR and removed app-feedback-program labels Aug 1, 2019

electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 1, 2019

codebytere approved these changes Aug 1, 2019

View reviewed changes

codebytere merged commit 0f78f8a into 6-0-x Aug 1, 2019

codebytere deleted the fix-linux-menu-crash-6-0-x branch August 1, 2019 15:05

Provide feedback