Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use WeakPtr to detect deletion to avoid crash on application menu #19257

Merged
merged 1 commit into from
Jul 31, 2019
Merged

fix: use WeakPtr to detect deletion to avoid crash on application menu #19257

merged 1 commit into from
Jul 31, 2019

Conversation

jkleinsc
Copy link
Contributor

@jkleinsc jkleinsc commented Jul 15, 2019 •
edited

Description of Change

Fixes #18436. This PR resolves a heap-use-after-free issue found by the AddressSanitizer. This issue happens when interacting with the Application Menu.

Checklist

Release Notes

Notes: Fixed crashes when using the application menu on Linux.

@jkleinsc jkleinsc requested a review from a team July 15, 2019 15:47
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 15, 2019
@jkleinsc jkleinsc requested a review from ckerr July 15, 2019 15:48
deepak1556
deepak1556 requested changes Jul 15, 2019
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on usage, but can you upstream this to get a better review ? we can pull back that patch, Thanks!

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 16, 2019
@jkleinsc
Copy link
Contributor Author

@robo upstream CL is here: https://chromium-review.googlesource.com/c/chromium/src/+/1714626

@jkleinsc
Copy link
Contributor Author

@robo the upstream patch has been approved. I updated this PR with the feedback provided in the CL.

@jkleinsc jkleinsc requested a review from deepak1556 July 31, 2019 19:26
@jkleinsc jkleinsc merged commit 3a6cafa into master Jul 31, 2019
@release-clerk
Copy link

release-clerk bot commented Jul 31, 2019

Release Notes Persisted

Fixed crashes when using the application menu.

@trop
Copy link
Contributor

trop bot commented Jul 31, 2019

I was unable to backport this PR to "6-0-x" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Jul 31, 2019

I was unable to backport this PR to "5-0-x" cleanly;
you will need to perform this backport manually.

@trop trop bot mentioned this pull request Jul 31, 2019
Merged
@trop trop bot removed the target/6-0-x label Jul 31, 2019
@trop
Copy link
Contributor

trop bot commented Jul 31, 2019

I have automatically backported this PR to "7-0-x", please check out #19558

This was referenced Jul 31, 2019
Closed
Merged
@trop
Copy link
Contributor

trop bot commented Aug 1, 2019

A maintainer has manually backported this PR to "6-0-x", please check out #19560

@trop trop bot added the in-flight/6-0-x label Aug 1, 2019
@jkleinsc jkleinsc deleted the fix-linux-menu-crash branch August 1, 2019 00:11
@jkleinsc jkleinsc mentioned this pull request Aug 1, 2019
Merged
4 tasks
@trop
Copy link
Contributor

trop bot commented Aug 1, 2019

A maintainer has manually backported this PR to "5-0-x", please check out #19561

@sofianguy sofianguy added this to Fixed in 5.0.9 in 5.0.x Aug 7, 2019
@sofianguy sofianguy added this to 7.0.0-beta.2 in 7.2.x Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@ckerr ckerr Awaiting requested review from ckerr

Assignees
No one assigned
Labels
None yet
Projects
No open projects
5.0.x
Fixed in 5.0.9
7.2.x
Fixed in 7.0.0-beta.2
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

electron crashes when closing application menu (armv7l)
2 participants
@jkleinsc @deepak1556