Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use i18nized strings in gtk dialog buttons #19760

Merged
merged 1 commit into from Aug 16, 2019
Merged

fix: use i18nized strings in gtk dialog buttons #19760

merged 1 commit into from Aug 16, 2019

Conversation

ckerr
Copy link
Member

@ckerr ckerr commented Aug 14, 2019

Backport of #19756

See that PR for details.

NB: trop failed so this is a manual backport.

CC @codebytere

Release Notes

Notes: Fixed i18n of GTK dialog buttons.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 14, 2019
@trop trop bot mentioned this pull request Aug 14, 2019
4 tasks
@ckerr ckerr changed the title fix: make i18n of gtk dialog buttons work fix: use i18nized strings in gtk dialog buttons Aug 14, 2019
@ckerr ckerr added semver/patch backwards-compatible bug fixes target/4-2-x labels Aug 14, 2019
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the backport assist :D

@codebytere
Copy link
Member

(took off the 5/4 labels since they failed and it's easier for trop if all the needs-manual are consolidated)

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 15, 2019
@ckerr ckerr merged commit 871f123 into 6-0-x Aug 16, 2019
@release-clerk
Copy link

release-clerk bot commented Aug 16, 2019

Release Notes Persisted

Fixed i18n of GTK dialog buttons.

@ckerr ckerr deleted the fix-i18n_6-0-x branch August 16, 2019 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants