fix: use GTK3 stock i18n strings #19756
Conversation
There was a problem hiding this comment.
NB: I'm not sure about not wrapping the strings with _(). What I'm thinking about here is that Chromium ships with code that doesn't wrap them, so I think it's worthwhile to test & see if this works without the gettext call.
Tested & WfM; see #19756 (comment) below
|
0816e6c seems to be working 👍 |
|
A maintainer has manually backported this PR to "6-0-x", please check out #19760 |
|
Release Notes Persisted
|
|
I was unable to backport this PR to "4-2-x" cleanly; |
|
I was unable to backport this PR to "5-0-x" cleanly; |
|
I was unable to backport this PR to "3-1-x" cleanly; |
|
I have automatically backported this PR to "7-0-x", please check out #19783 |
|
A maintainer has manually backported this PR to "5-0-x", please check out #19801 |
* fix: i18n of gtk msgbox buttons similar to #19756 (12df0e8) but for messageboxes * refactor: DRY the gtk+ button mnemonics * fix: don't compile gtk_util on non-Linux platforms rename from `gtk_util.[cc,h]` to `util_gtk.[cc,h]` so that it gets picked up by the `extra_source_filters` rule in `BUILD.gn`. * fix: make linter happy It really shows that I cannot build locally atm... :P
* fix: i18n of gtk msgbox buttons similar to #19756 (12df0e8) but for messageboxes * refactor: DRY the gtk+ button mnemonics * fix: don't compile gtk_util on non-Linux platforms rename from `gtk_util.[cc,h]` to `util_gtk.[cc,h]` so that it gets picked up by the `extra_source_filters` rule in `BUILD.gn`. * fix: make linter happy It really shows that I cannot build locally atm... :P
Description of Change
Fixes #19755.
We should be using GTK stock labels on GTK3; the translations will be broken for those using GTK4 but it's in our best interest for now to wait and provide internationalized strings when GTK provides support for it.
cc @ckerr @erickzhao
Checklist
npm testpassesRelease Notes
Notes: Correctly internationalize i18n in GTK-based Linux dialogs.