fix: disable LayoutNG to prevent random crashes in selection calcuations #19808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
added
the
fast-track 🚅
codebytere
approved these changes
Aug 16, 2019
deepak1556
approved these changes
Aug 16, 2019
|
Thanks Sam! 😍 |
ckerr
approved these changes
Aug 16, 2019
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=992929
CL that caused it: https://chromium-review.googlesource.com/c/chromium/src/+/1598319
Even Chrome doesn't have LayoutNG enabled in C76 and if you try to turn it on Chrome violently crashes so I think we're right to turn this off.
In particular LayoutNG causes a crash when selecting "wbr" elements in certain fonts under certain layout conditions. (I can't be much more specific or do a repro outside of a Slack specific message).
Notes: Fixed occasional crashes while selecting text