Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable LayoutNG to prevent random crashes in selection calcuations #19808

Merged
merged 2 commits into from Aug 17, 2019
Merged

fix: disable LayoutNG to prevent random crashes in selection calcuations #19808

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa51efb
fix: disable LayoutNG to prevent random crashes in selection calcuations
MarshallOfSound Aug 16, 2019
a81e654
Update atom_browser_main_parts.cc
MarshallOfSound Aug 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions atom/browser/atom_browser_main_parts.cc
View file
Open in desktop
Expand Up @@ -48,6 +48,7 @@
#include "services/device/public/mojom/constants.mojom.h"
#include "services/network/public/cpp/features.h"
#include "services/service_manager/public/cpp/connector.h"
#include "third_party/blink/public/common/features.h"
#include "ui/base/idle/idle.h"
#include "ui/base/material_design/material_design_controller.h"
#include "ui/base/ui_base_switches.h"
Expand Down Expand Up @@ -209,6 +210,9 @@ void AtomBrowserMainParts::InitializeFeatureList() {
// when node integration is enabled.
disable_features +=
std::string(",") + features::kSpareRendererForSitePerProcess.name;
// Disable LayoutNG as it still isn't fully enabled in Chrome and currently
// is still causing crashes during every day use such as text selection.
disable_features += std::string(",") + blink::features::kLayoutNG.name;
auto feature_list = std::make_unique<base::FeatureList>();
feature_list->InitializeFromCommandLine(enable_features, disable_features);
base::FeatureList::SetInstance(std::move(feature_list));
Expand Down