Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blurry rendering on Mac OS X after switching from non-retina display to retina display #21393

Closed
3 tasks done
aterenin opened this issue Dec 5, 2019 · 7 comments
Closed
3 tasks done

Comments

@aterenin
Copy link

aterenin commented Dec 5, 2019

NOTE: I previously reported this at #21229 which was closed after someone was unable to reproduce it. I insist that this bug is present, and is an Electron bug, because it occurs on Caprine, Slack, WhatsApp, VS Code, and my own home-built Google Photos desktop app. After the issue was closed, @nielsvandepas was able to reproduce the bug, but the issue was not reopened after commented. I'm not sure why this issue couldn't be reproduced using the steps I've given, so I'm attaching screenshots. Sorry for duplicate - I don't have permissions for reopening the other issue.

Preflight Checklist

  • I have read the Contributing Guidelines for this project.
  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version:
    7
  • Operating System:
    Mac OS X
  • Last Known Working Electron version:
    N/A

To Reproduce

  1. Connect MacBook to a non-retina display - in my case, a 40" 4k display connected via DisplayPort with standard scaling (i.e. full resolution, not retina-like 1080p scaled up to 4k).
  2. Close the MacBook lid.
  3. Open an Electron app.
  4. Unplug the display.
  5. Open the MacBook lid. Electron app is blurry.

Screenshots

Screen Shot 2019-12-05 at 11 31 43 AM

Screen Shot 2019-12-05 at 11 32 52 AM

Screen Shot 2019-12-05 at 11 32 27 AM

Screen Shot 2019-12-05 at 11 33 12 AM

@aterenin aterenin changed the title Blurry rendering on Mac OS X after switching from non-retina display to retina displa Blurry rendering on Mac OS X after switching from non-retina display to retina display Dec 5, 2019
@ckerr
Copy link
Member

ckerr commented Dec 5, 2019

Alexander, to help narrow down the problem, could you see if the same blurry rendering occurs under the same circumstances in Chrome 78 by itself?

In addition, could you see if the problem persists in the Electron 8 betas (e.g. by using electron-fiddle, choosing an 8 beta, and running demo code)?

@EllDoubleYew
Copy link

EllDoubleYew commented Dec 6, 2019

I see this issue a lot on 7, but the actual steps to reproduce it are hard for me to pin down:

  • It usually happens in the morning when I first open up my laptop and plug it into my external monitor.
  • Dragging the window over to my external display and back to my Retina display will bring my window back to the correct resolution.
  • Even after disconnecting the external display I still see the low resolution window on my Retina display. If I quit the application and re-open it it is still at a low resolution. I have to either restart my machine or reconnect to an external display to bring it back to the correct resolution.
  • I'm using one 1080p secondary display and a 2880 x 1880 Retina display on my MBP.

Wish I could give more sure-fire steps to reproduce but I can't find a method that always results in finding the bug.

@ckerr for what its worth I couldn't immediately reproduce this in 8, but I'll have to leave the 8 fiddle running for a few days in the background and see if the resolution ever changes after connecting/disconnecting from my external display.

@sofianguy sofianguy added this to Unsorted Issues in 7.2.x Dec 9, 2019
@karipov
Copy link

karipov commented Dec 13, 2019

Hi,

I'd like to add on to this, as I've experienced this with both VS Code, but more interestingly the Spotify Desktop App which uses the Chromium Embedded Framework. Could it be deeper than just an electron issue?

I'm seeing this after connecting my 2K 16:10 MacBook 13" to a Dell U2518D (also 2K but 16:9).

@obahareth
Copy link

I believe the root cause might be this Chromium issue.

@eric1iu
Copy link

eric1iu commented Jan 15, 2020

I've experienced the same issue with Slack and VS Code on my Catalina mbp. As a workaround without restart the apps, I open System Preferences / Display do a resolution scaled change and revert it back.

@deepak1556
Copy link
Member

Thanks @obahareth , yes thats the issue, have backported the patch #21872

@deepak1556
Copy link
Member

Fixed in c7bb1d0

@sofianguy sofianguy moved this from Unsorted Issues to Fixed for Next Release in 7.2.x Feb 15, 2020
@sofianguy sofianguy moved this from Fixed for Next Release to Fixed in 7.1.11 in 7.2.x Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
7.2.x
Fixed in 7.1.11
Development

No branches or pull requests

7 participants