Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid contextBridge double free on garbage collection #21736

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jan 11, 2020

Backport of #21592

See that PR for details.

Notes: Fixed a crash in contextBridge that happens on garbage collection

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 11, 2020
@trop trop bot requested a review from loc January 11, 2020 00:00
@trop trop bot added 7-1-x backport This is a backport PR labels Jan 11, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jan 11, 2020
@MarshallOfSound MarshallOfSound merged commit 704cdd3 into 7-1-x Jan 11, 2020
@release-clerk
Copy link

release-clerk bot commented Jan 11, 2020

Release Notes Persisted

Fixed a crash in contextBridge that happens on garbage collection

@nornagon nornagon deleted the trop/7-1-x-bp-fix-avoid-contextbridge-double-free-on-garbage-collection-1578700802801 branch April 15, 2020 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7-1-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants