fix: avoid contextBridge double free on garbage collection #21592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
reviewed
Dec 20, 2019
| @@ -76,11 +78,7 @@ WeakGlobalPairNode::WeakGlobalPairNode(WeakGlobalPair pair) { | |||
| this->pair = std::move(pair); | |||
| } | |||
|
|
|||
| WeakGlobalPairNode::~WeakGlobalPairNode() { | |||
| if (next) { | |||
There was a problem hiding this comment.
how... was this ever sensible?
There was a problem hiding this comment.
I think past me reasoned that deleting the head of a list should delete everything in the list without thinking about how this particular linked list was being used
nornagon
approved these changes
Dec 20, 2019
MarshallOfSound
approved these changes
Dec 20, 2019
|
Release Notes Persisted
|
This was referenced Jan 11, 2020
|
I have automatically backported this PR to "8-x-y", please check out #21735 |
|
I have automatically backported this PR to "7-1-x", please check out #21736 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Speculatively fix a crash in contextBridge. Because the elements in the hash-collided linked list are each subject to an object life monitor, they will free themselves. So it's redundant (and crash-y) to free next in the destructor.
Additionally, while we're at it, correct the pointer resetting of the linked list shuffling in the destructor.
Checklist
npm testpassesRelease Notes
Notes: Fixed a crash in contextBridge that happens on garbage collection