Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use NSVisualEffectMaterial* constants directly #22149

Merged
merged 1 commit into from Feb 12, 2020
Merged

refactor: use NSVisualEffectMaterial* constants directly #22149

merged 1 commit into from Feb 12, 2020

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Feb 11, 2020 •
edited

Backport of #22121.

Notes: none.

@codebytere codebytere requested a review from a team February 11, 2020 16:31
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 11, 2020
@trop trop bot mentioned this pull request Feb 11, 2020
Merged
@trop trop bot added 8-x-y backport This is a backport PR labels Feb 11, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 11, 2020
@trop trop bot mentioned this pull request Feb 11, 2020
Merged
4 tasks
jkleinsc
jkleinsc requested changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did not update 8-x-y CI to use the 10.15 SDK, so I don't think we should backport this to 8-x-y!

@codebytere
Copy link
Member Author

@jkleinsc that shouldn't affect this PR; it doesn't need the 10.15 sdk :)

jkleinsc
jkleinsc approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I misunderstood and thought this change would only work with 10.15 sdk and higher.

@jkleinsc jkleinsc merged commit c8e2a62 into 8-x-y Feb 12, 2020
@release-clerk
Copy link

release-clerk bot commented Feb 12, 2020

Release Notes Persisted

none.

@jkleinsc jkleinsc deleted the nsvisualeffect-bp-8 branch February 12, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
8-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @jkleinsc @zcbenz