New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use NSVisualEffectMaterial* constants directly #22121
Conversation
bb70d1f
to
63f810a
Compare
@@ -1455,8 +1455,7 @@ void ViewDidMoveToSuperview(NSView* self, SEL _cmd) { | |||
relativeTo:nil]; | |||
} | |||
|
|||
std::string dep_warn = | |||
" has been deprecated and will be removed in a future version of macOS."; | |||
std::string dep_warn = " has been deprecated and removed as of macOS 10.15."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apple's docs indicate that all below deprecated APIs were removed in 10.15.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this PR should apply to 8-x-y as we didn't backport/need CI changes there.
No Release Notes |
/trop run backport-to 8-x-y |
The backport process for this PR has been manually initiated - |
I have automatically backported this PR to "9-x-y", please check out #22148 |
I was unable to backport this PR to "8-x-y" cleanly; |
@codebytere has manually backported this PR to "8-x-y", please check out #22149 |
Description of Change
We wre previously static casting these because our minimum SDK was too low to directly use the constants, but now that we're on 10.15 we can use them directly, and so this PR updates them to do so.
cc @ckerr @jkleinsc @zcbenz
Checklist
npm test
passesRelease Notes
Notes: none