Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: crash on custom printing margins #22186

Merged
merged 1 commit into from Feb 13, 2020
Merged

fix: crash on custom printing margins #22186

merged 1 commit into from Feb 13, 2020

Conversation

codebytere
Copy link
Member

Backport of #22164.

See that PR for details.

Notes: Fixed a crash in webContents.print() with custom print margins.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 13, 2020
@trop trop bot mentioned this pull request Feb 13, 2020
Merged
5 tasks
@trop trop bot added 8-x-y backport This is a backport PR labels Feb 13, 2020
@codebytere codebytere requested a review from a team February 13, 2020 18:08
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 13, 2020
@codebytere codebytere changed the title fix: crash on custom printing margins (#22164) fix: crash on custom printing margins Feb 13, 2020
@codebytere codebytere merged commit 89607e6 into 8-x-y Feb 13, 2020
@release-clerk
Copy link

release-clerk bot commented Feb 13, 2020

Release Notes Persisted

Fixed a crash in webContents.print() with custom print margins.

@codebytere codebytere deleted the printing-backport-8 branch February 13, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
8-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @jkleinsc