fix: crash on custom printing margins #22164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
approved these changes
Feb 12, 2020
There was a problem hiding this comment.
LGTM, I believe all these validation crash cases are going to be covered in #22049 ?
zcbenz
approved these changes
Feb 12, 2020
jkleinsc
approved these changes
Feb 12, 2020
ckerr
approved these changes
Feb 12, 2020
|
Release Notes Persisted
|
|
I was unable to backport this PR to "8-x-y" cleanly; |
|
I was unable to backport this PR to "7-1-x" cleanly; |
|
I have automatically backported this PR to "9-x-y", please check out #22185 |
|
@codebytere has manually backported this PR to "8-x-y", please check out #22186 |
codebytere
added a commit
that referenced
this pull request
Feb 13, 2020
|
@codebytere has manually backported this PR to "7-1-x", please check out #22187 |
codebytere
added a commit
that referenced
this pull request
Feb 14, 2020
codebytere
added a commit
that referenced
this pull request
Feb 14, 2020
codebytere
added a commit
that referenced
this pull request
Feb 14, 2020
codebytere
added a commit
that referenced
this pull request
Feb 14, 2020
zcbenz
pushed a commit
that referenced
this pull request
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #21167.
Chromium changed their margin key settings such that custom margins should be set as their own dictionary, and without that will fail conversion validation and crash. This fixes that.
cc @zcbenz @deepak1556 @nornagon
Checklist
npm testpassesRelease Notes
Notes: Fixed a crash in
webContents.print()with custom print margins.