fix: Make the --disable-color-correct-rendering switch work again
#23900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
This regressed once again in Electron 8 due to Chromium changes. Test Plan: - Confirm that test case from #15898 (comment) now works Notes: Fix disabling color correct rendering with `--disable-color-correct-rendering`
codebytere
approved these changes
Jun 3, 2020
|
Release Notes Persisted
|
codebytere
deleted the
trop/9-x-y-bp-fix-make-the-disable-color-correct-rendering-switch-work-again-1591083108222
branch
|
I tested this fix on v9.0.3 today. The switch |
|
I tested this fix on v16.0.7 down to v12.2.3 today. The switch --disable-color-correct-rendering still doesn't work. It seems like everything is treated as sRGB and transformt from sRGB to display space, even if an image already is in display space and has the corresponding icc profile attached. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #23787
See that PR for details.
Notes: Fix disabling color correct rendering with
--disable-color-correct-rendering