fix: Make the --disable-color-correct-rendering switch work again
#23787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This regressed once again in Electron 8 due to Chromium changes. Test Plan: - Confirm that test case from electron#15898 (comment) now works Notes: Fix disabling color correct rendering with `--disable-color-correct-rendering`
|
@codebytere Could you add the target lables for Electron 8/9/10 and also approve and merge this? 🙏 |
|
@poiru i added the labels but can you please explain what exactly regressed (e.g. in Chromium) and what you did to fix it in the PR body? |
|
@codebytere Done! |
alexeykuzmin
approved these changes
May 28, 2020
poiru
added a commit
to poiru/electron
that referenced
this pull request
May 28, 2020
…8-x-y) Backport of electron#23787 See that PR for details. Notes: Fix disabling color correct rendering with `--disable-color-correct-rendering`
poiru
added a commit
to poiru/electron
that referenced
this pull request
May 28, 2020
…8-x-y) Backport of electron#23787 See that PR for details. Notes: Fix disabling color correct rendering with `--disable-color-correct-rendering`
poiru
added a commit
to poiru/electron
that referenced
this pull request
May 29, 2020
…8-x-y) Backport of electron#23787 See that PR for details. Notes: Fix disabling color correct rendering with `--disable-color-correct-rendering`
zcbenz
approved these changes
Jun 2, 2020
|
Release Notes Persisted
|
This was referenced Jun 2, 2020
|
I have automatically backported this PR to "10-x-y", please check out #23899 |
|
I have automatically backported this PR to "9-x-y", please check out #23900 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regressed once again in Electron 8 because some of the conflicting
patch hunks were discarded or resolved incompletely during Chromium
upgrades. To get this working again, we...
cc/trees/layer_tree_host_impl.ccchange removed in c68b6e6#diff-35e7ec7b0ce7f31ff9ad312e8b43ac0cui/gfx/mac/io_surface.ccchanges in 33129c9#diff-35e7ec7b0ce7f31ff9ad312e8b43ac0cTest Plan:
Notes: Fix disabling color correct rendering with
--disable-color-correct-rendering