Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Frameless window displays frame while opening #30760

Closed
3 tasks done
samuelmaddock opened this issue Aug 30, 2021 · 12 comments · Fixed by #32692 or #35189
Closed
3 tasks done

[Bug]: Frameless window displays frame while opening #30760

samuelmaddock opened this issue Aug 30, 2021 · 12 comments · Fixed by #32692 or #35189
Labels
16-x-y 17-x-y 18-x-y 19-x-y bug 🪲 has-repro-gist Issue can be reproduced with code at https://gist.github.com/ platform/windows status/confirmed A maintainer reproduced the bug or agreed with the feature
Projects

Comments

@samuelmaddock
Copy link
Member

Preflight Checklist

Electron Version

14.0.0-beta.25

What operating system are you using?

Windows

Operating System Version

Windows 10 21H1

What arch are you using?

x64

Last Known Working Electron version

14.0.0-beta.3

Expected Behavior

Opening a frameless window and immediately revealing it (instead of waiting for ready-to-show event) shows no content inside of the window.

Actual Behavior

Opening a frameless window and immediately revealing it (instead of waiting for ready-to-show event) shows an older style window frame with no content inside.

14.0.0-beta.3 14.0.0-beta.5
image image
2021-08-30_18-21-42.mp4

Testcase Gist URL

https://gist.github.com/4256f388d41ef0d974645a11ab72b1fe

Additional Information

This may not be a bug, but I felt that displaying the frame while the window is opening was maybe not intentional.

@samuelmaddock samuelmaddock added platform/windows bug 🪲 status/confirmed A maintainer reproduced the bug or agreed with the feature has-repro-gist Issue can be reproduced with code at https://gist.github.com/ 14-x-y 15-x-y labels Aug 30, 2021
@codebytere codebytere self-assigned this Aug 31, 2021
@samuelmaddock
Copy link
Member Author

Setting backgroundColor to #00000000 (alpha included) shows this until the window is resized:

image

@aleksey-hoffman
Copy link

aleksey-hoffman commented Aug 31, 2021

I also noticed this issue. It's reproducible in v15.0.0-beta.1 as well

@mustafaabobakr
Copy link

Hi
Any news on this?

@codebytere
Copy link
Member

codebytere commented Jan 31, 2022

Bisected to v14.0.0-beta.3...v14.0.0-beta.5

@mustafaabobakr
Copy link

mustafaabobakr commented Jan 31, 2022

@codebytere

Hi, am using v16.0.4 should I downgrade to v13 ?

@deepak1556
Copy link
Member

Reopening for #33599

@deepak1556 deepak1556 reopened this Apr 5, 2022
@deepak1556
Copy link
Member

Although there is a user facing workaround, it is worth investigating why this code path regressed with the chromium roll bisected in this range #30760 (comment)

@Tarrowren
Copy link

I also noticed that the actual size of the window is a turn smaller than it looks. When dragging the scrollbar with the mouse you often accidentally click on the window zoom.
1
2

@infinnie
Copy link

infinnie commented Jun 27, 2022

I also noticed that the actual size of the window is a turn smaller than it looks. When dragging the scrollbar with the mouse you often accidentally click on the window zoom.
1

But it’s been so since at least Electron 13.x.

@rzhao271
Copy link
Contributor

rzhao271 commented Jul 21, 2022

Bisected to 172ac25, though a lot of things happened during that roll: https://chromium.googlesource.com/chromium/src/+log/92.0.4511.0..93.0.4530.0?n=10000&pretty=fuller

@pushkin-
Copy link

pushkin- commented Aug 4, 2022

@samuelmaddock Is this a dupe? Also, could your PR fix this issue?

@deepak1556
Copy link
Member

@pushkin- #30024 is not a dupe although they share the same root cause of how the style WS_THICKFRAME presence impacts WS_CAPTION for frameless windows. Also, #35189 currently does not address it. It only tries to restore the behavior of frameless window which are resizable to how it was before the chromium roll #30760 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
16-x-y 17-x-y 18-x-y 19-x-y bug 🪲 has-repro-gist Issue can be reproduced with code at https://gist.github.com/ platform/windows status/confirmed A maintainer reproduced the bug or agreed with the feature
Projects
15-x-y
Does Not Block Stable
9 participants