Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: app.requestSingleInstanceLock on Windows should use MessageWindow to send back acknowledgement #34235

Closed
rzhao271 opened this issue May 13, 2022 · 2 comments
Labels
platform/windows stale status/confirmed A maintainer reproduced the bug or agreed with the feature

Comments

@rzhao271
Copy link
Contributor

app.requestSingleInstanceLock on Windows currently (Electron 18.2.3) uses a named pipe to send data (called an acknowledgement) from the first instance back to the second instance. A potential issue with named pipes is that multiple "second instances" might open at the same time, in which case the acknowledgement might not get sent back to the correct second instance in the case that the named pipe name doesn't distinguish between which instance connected. I still have to read up on #34139 and understand how exactly the pipe name is being created, though.

By using message windows, I'm thinking that we can also start up the second instance's message window ahead of time, so that the first instance can directly send back a message, without having to first go through a handshake.

CC @deepak1556

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@github-actions github-actions bot added the stale label Oct 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

This issue has been closed due to inactivity, and will not be monitored. If this is a bug and you can reproduce this issue on a supported version of Electron please open a new issue and include instructions for reproducing the issue.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/windows stale status/confirmed A maintainer reproduced the bug or agreed with the feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants