Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New makeSingleInstance API #12782

Merged
merged 7 commits into from May 7, 2018
Merged

New makeSingleInstance API #12782

merged 7 commits into from May 7, 2018

Commits on May 2, 2018

  1. Refactor app.makeSingleInstance 

    * new API `app.isPrimaryInstance()`
* new API `app.isSingleInstance()`
* new event `app.on('second-instance')`
* deprecated old syntax `app.makeSingleInstance(cb)`
* deprecated old syntax of `app.makeSingleInstance() --> bool` in favor
of `app.isPrimaryInstance()`
    @MarshallOfSound
    MarshallOfSound committed May 2, 2018
    Copy the full SHA
    01bef05 View commit details
    Browse the repository at this point in the history

  2. Fix spec, we don't need process.nextTick hacks any more

    @MarshallOfSound
    MarshallOfSound committed May 2, 2018
    Copy the full SHA
    cc3062a View commit details
    Browse the repository at this point in the history

  3. Make deprecation TODO for the return value of makeSingleInstance

    @MarshallOfSound
    MarshallOfSound committed May 2, 2018
    Copy the full SHA
    24667e1 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2018

  1. Refactor makeSingleInstance to requestSingleInstanceLock and add appr… 

    …opriate deprecation comments
    @MarshallOfSound
    MarshallOfSound committed May 3, 2018
    Copy the full SHA
    0e83284 View commit details
    Browse the repository at this point in the history

  2. I swear this isn't tricking the linter

    @MarshallOfSound
    MarshallOfSound committed May 3, 2018
    Copy the full SHA
    067234e View commit details
    Browse the repository at this point in the history

  3. Make const

    @MarshallOfSound
    MarshallOfSound committed May 3, 2018
    Copy the full SHA
    85e3d16 View commit details
    Browse the repository at this point in the history

  4. Add deprecation warnings for release, and add to planned-breaking-cha… 

    …nges
    @MarshallOfSound
    MarshallOfSound committed May 3, 2018
    Copy the full SHA
    d9b6a24 View commit details
    Browse the repository at this point in the history