Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add options to webContents.loadFile #14515

Merged
merged 1 commit into from Sep 11, 2018
Merged

feat: add options to webContents.loadFile #14515

merged 1 commit into from Sep 11, 2018

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Sep 9, 2018 •
edited

Description of Change

Allows passing the following options to url.format called by webContents.loadFile:

  • query
  • search
  • hash
Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines
Release Notes

Notes: Added options to webContents.loadFile allowing to pass query, search, hash to url.format.

@miniak miniak requested review from a team September 9, 2018 20:32
alexeykuzmin
alexeykuzmin approved these changes Sep 9, 2018
View reviewed changes
Copy link
Contributor

@alexeykuzmin alexeykuzmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
Only one small suggestion up there ^

@MarshallOfSound MarshallOfSound added the semver/minor backwards-compatible functionality label Sep 11, 2018
@MarshallOfSound MarshallOfSound merged commit 58577bd into master Sep 11, 2018
@release-clerk
Copy link

release-clerk bot commented Sep 11, 2018

Release Notes Persisted

Added options to webContents.loadFile allowing to pass query, search, hash to url.format.

@MarshallOfSound MarshallOfSound deleted the miniak/load-file-options branch September 11, 2018 07:56
@ckerr ckerr mentioned this pull request Dec 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@nornagon nornagon Awaiting requested review from nornagon

@alexeykuzmin alexeykuzmin Awaiting requested review from alexeykuzmin

@ckerr ckerr Awaiting requested review from ckerr

@codebytere codebytere Awaiting requested review from codebytere

Assignees
No one assigned
Labels
semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miniak @alexeykuzmin @MarshallOfSound