Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow stream protocols to return headers with multiple values #14887

Merged
merged 4 commits into from Oct 25, 2018
Merged

fix: allow stream protocols to return headers with multiple values #14887

merged 4 commits into from Oct 25, 2018

Commits on Oct 23, 2018

  1. fix: allow stream protocols to return headers with multiple values 

    This allows stream protocols to return headers with multiple values as
an array of values.

Fixes #14778
    @ibash
    ibash committed Oct 23, 2018
    Copy the full SHA
    b15fd19 View commit details
    Browse the repository at this point in the history

  2. Prefer ConvertFromV8

    @ibash
    ibash committed Oct 23, 2018
    Copy the full SHA
    5cb932b View commit details
    Browse the repository at this point in the history

  3. Cleanup header conversion 

    1. Deduplicate the code by using a lambda
2. Remove duplicate calls to headers->Get(key)
    @ibash
    ibash committed Oct 23, 2018
    Copy the full SHA
    9108958 View commit details
    Browse the repository at this point in the history

  4. Fix broken test 

    Headers with multiple values are now being converted correctly, this
test asserted the wrong behavior.
    @ibash
    ibash committed Oct 23, 2018
    Copy the full SHA
    463fbc3 View commit details
    Browse the repository at this point in the history