feat: remove needless additional mojave dark mode APIs #14895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckerr
approved these changes
Oct 1, 2018
codebytere
approved these changes
Oct 1, 2018
…ow to use the macOS replacement
MarshallOfSound
force-pushed
the
mojave-dark-mode-follow-up
branch
from
fa1f601
to
58d2936
Compare
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, these 2 APIs are not required, you can compile on < 10.14 SDK and still have macOS adjust the appearance of your app automatically for you. You just need the
NSRequiresAquaSystemAppearancekey set tofalsein your app'sInfo.plist. We can't set this by default in Electron because you should only set it if your app actually supports dark mode but we can add support toelectron-packagerand document this keys behavior in our dark mode docs.Refs: electron/packager#893 .
Refs: https://developer.apple.com/documentation/appkit/nsappearancecustomization/choosing_a_specific_appearance_for_your_app
Notes: Simplified mojave dark mode APIs