Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed for(... i++) to for .. of #15009

Closed
wants to merge 1 commit into from
Closed

Conversation

AnnuJoshi
Copy link

Description of Change
Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines
Release Notes

Notes:

@AnnuJoshi AnnuJoshi requested a review from a team October 7, 2018 14:40
@welcome
Copy link

welcome bot commented Oct 7, 2018

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codebytere
Copy link
Member

hi @AnnuJoshi while we appreciate your contribution this does not qualify as a typo or issue and is therefore not something we feel needs to be changed. In the future, we would also appreciate if you would follow commit guidelines and fill out the provided checklist in order for your PRs to be reviewed.

@ckerr
Copy link
Member

ckerr commented Oct 8, 2018

@codebytere there is definitely some non-typo / non-bug work that would be accepted in the docs, eg. #14842 to ES6ify the code examples in the documentation.

I agree with turning down this specific PR because it's too minor a change and because of issues with the proposed code (e.g. no const/let before the scope variable, bug in treating for-of like for-in, etc) but I would not want people reading this page to think we only want typo / bugfix changes in our docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants