Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Introduce LocationProxy for BrowserWindowProxy #15019

Merged
merged 3 commits into from Dec 4, 2018
Merged

fix: Introduce LocationProxy for BrowserWindowProxy #15019

merged 3 commits into from Dec 4, 2018

Conversation

Anrock
Copy link
Contributor

@Anrock Anrock commented Oct 8, 2018

Fixes #15017

Description of Change

Implements proxy Location object for BrowserWindowProxy

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines
Release Notes

Notes: Implement proper Location object for BrowserWindowProxy

@Anrock Anrock requested a review from a team October 8, 2018 12:31
@codebytere
Copy link
Member

@Anrock did you test this locally? i'm seeing 10 test failures for most builds that all look related

@Anrock
Copy link
Contributor Author

Anrock commented Oct 8, 2018

@codebytere no, i didn't - once again git pull rendered master unbuildable for me. Therefore marked as WIP.

However i'm interested in top-level review if this approach is viable and if it's a welcomed change in regards of electron architecture..

@Anrock Anrock changed the title WIP: Introduce LocationProxy for BrowserWindowProxy fix: Introduce LocationProxy for BrowserWindowProxy Oct 9, 2018
@Anrock
Copy link
Contributor Author

Anrock commented Oct 9, 2018

Removing WIP: works for me, usual 4-5 test fails as on master.

@Anrock
Copy link
Contributor Author

Anrock commented Oct 9, 2018

Is there relevant unit tests for location object i should change?

@Anrock
Copy link
Contributor Author

Anrock commented Oct 11, 2018

@codebytere ping

@alexeykuzmin
Copy link
Contributor

@Anrock

https://circleci.com/gh/electron/electron/82004
Among all failed tests only these two look like real failures:

  • "chromium feature window.open defines a window.location getter"
  • "BrowserWindow module contextIsolation option with and without sandbox option doesn't break ipc serialization"

Can you please fix them?

@alexeykuzmin alexeykuzmin added the semver/major incompatible API changes label Oct 19, 2018
@Anrock
Copy link
Contributor Author

Anrock commented Oct 19, 2018

@alexeykuzmin i'll take a look at it as soon as i can. Don't have much free time for it, unfortunately.

Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I have fixed the failing tests by adding a setter for window.location.

@zcbenz zcbenz merged commit 5bc86ea into electron:master Dec 4, 2018
@release-clerk
Copy link

release-clerk bot commented Dec 4, 2018

Release Notes Persisted

Implement proper Location object for BrowserWindowProxy

@Anrock Anrock deleted the child-window-location branch December 4, 2018 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/major incompatible API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants