chore: remove macOS 10.9 specific code #15174
Conversation
miniak
force-pushed
the
miniak/drop-mavericks
branch
from
20dfcc9
to
a08be1b
Compare
|
@MarshallOfSound can you please review? |
miniak
force-pushed
the
miniak/drop-mavericks
branch
from
a08be1b
to
f5944df
Compare
| shell_->fullscreen_window_title())) { | ||
| [window setTitleVisibility:NSWindowTitleVisible]; | ||
| } | ||
| // For frameless window we don't show set title for normal mode since the |
There was a problem hiding this comment.
I'm concerned that this diff still shows with w=1 (ignore whitespace changes).
Can you verify that the line endings and tabs vs spaces haven't changed in this section?
There was a problem hiding this comment.
@MarshallOfSound SourceTree shows this properly. I did check it and I am not changing newlines and/or indentation (tabs vs. spaces)
miniak
force-pushed
the
miniak/drop-mavericks
branch
from
f5944df
to
39bef61
Compare
miniak
changed the title
miniak
force-pushed
the
miniak/drop-mavericks
branch
from
39bef61
to
ab342f6
Compare
miniak
requested review from
nornagon,
ckerr,
codebytere,
deepak1556 and
alexeykuzmin
There was a problem hiding this comment.
Good catch @nornagon Missed that patch completely as the diff was minimized,
|
@MarshallOfSound if we are not comfortable with changing Chromium’s deployment target, then I will just close this PR and re-open again when we update to a version, which does change it to 10.10 There are a few changes that can be done without bumping the deployment target, but I think all the cleanup should probably be done together. |
Description of Change
Follow up to #15357.
Bump the macOS deployment target to 10.10 and remove macOS 10.9 specific code.
Checklist
npm testpassesRelease Notes
Notes: macOS deployment target bumped to 10.10.