Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove potential double free when managing WebContents #15280

Merged
merged 2 commits into from Oct 22, 2018
Merged

refactor: remove potential double free when managing WebContents #15280

merged 2 commits into from Oct 22, 2018

Commits on Oct 19, 2018

  1. refactor: remove -new-contents-created event 

    Chromium expects us to take ownership of WebContents in AddNewContents,
we should not create V8 wrapper in WebContentsCreated, otherwise we
would have WebContents being managed by 2 unique_ptr at the same time.
    @zcbenz
    zcbenz committed Oct 19, 2018
    Copy the full SHA
    3bfe073 View commit details
    Browse the repository at this point in the history

  2. refactor: make CreateAndTake take unique_ptr

    @zcbenz
    zcbenz committed Oct 19, 2018
    Copy the full SHA
    2ea8d9e View commit details
    Browse the repository at this point in the history